cli/command/volume: various fixes and improvements in tests #5782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/testing
area/volumes
kind/refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5782 +/- ##
==========================================
+ Coverage 59.42% 59.43% +0.01%
==========================================
Files 347 347
Lines 29398 29398
==========================================
+ Hits 17469 17472 +3
+ Misses 10957 10954 -3
Partials 972 972 |
thaJeztah
commented
Feb 3, 2025
| cmd.Flags().Set("topology-preferred", "region=R1,zone=Z2") | ||
| cmd.Flags().Set("topology-preferred", "region=R1,zone=Z3") | ||
|
|
||
| cmd.Execute() |
There was a problem hiding this comment.
This test was ... not testing 😂
Signed-off-by: Sebastiaan van Stijn <[email protected]>
…ments - assert unhandled error - use sub-tests - add test-case for conflicting options (both flag and name) - reset command-args to prevent test failing when running from pre-compiled test-binary - use a const and a slightly more unique name for the volume-name - discard stdout/stderr output Signed-off-by: Sebastiaan van Stijn <[email protected]>
- assert unhandled error - reset command-args to prevent test failing when running from pre-compiled test-binary - use a const and a slightly more unique name for the volume-name - discard stdout/stderr output Signed-off-by: Sebastiaan van Stijn <[email protected]>
- assert unhandled error - use sub-tests - use slightly more unique volume-names - discard stdout/stderr output Signed-off-by: Sebastiaan van Stijn <[email protected]>
…ctor - assert unhandled error - discard stdout/stderr output Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
volume_tests_clean
branch
from
341e665 to
31b8198
Compare
vvoland
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/command/volume: TestVolumeCreateErrors: assert unhandled errors
cli/command/volume: TestVolumeCreateWithName: minor fixes and improvements
cli/command/volume: TestVolumeCreateWithFlags: minor fixes
cli/command/volume: TestVolumeCreateCluster: minor fixes and refactor
cli/command/volume: TestVolumeCreateClusterOpts: minor fixes and refactor
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)